Skip to content

fix: #160 disabling automatic clock-outs #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2020
Merged

fix: #160 disabling automatic clock-outs #161

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64dacf0
fix: #160 disabling automatic clock-outs
enriquezrene Jun 1, 2020
e386e37
fix: #160 disabling automatic clock-outs
enriquezrene Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: #160 disabling automatic clock-outs
  • Loading branch information
@enriquezrene
enriquezrene committed Jun 1, 2020
commit e386e3790bbb0ec50fee5212b9ba1fc9a35076db
5 changes: 5 additions & 0 deletions time_tracker_api/time_entries/time_entries_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,11 @@ def find_running(self):
time_entry = self.repository.find_running(
event_ctx.tenant_id, event_ctx.user_id
)
# TODO: we need to make this work using the users time zone
# This is disabled as part of https://github.com/ioet/time-tracker-backend/issues/160
# Remove all these comments after implementing
# https://github.com/ioet/time-tracker-backend/issues/159
# https://github.com/ioet/time-tracker-backend/issues/162
# self.stop_time_entry_if_was_left_running(time_entry)
Copy link
Contributor

@Angeluz-07 Angeluz-07 Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add little TODO here to add some context to this comment. Something like "Refactor automatic clock-out to consider local timezones". By using the word "refactor" I intend to include the intention to either remove the whole logic around this or extend it taking into account local timezones.

return time_entry

Expand Down