Feature/get time entries per month and year#106 #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliuX
reviewed
Apr 28, 2020
Contributor
EliuX
left a comment
EliuX
left a comment
There was a problem hiding this comment.
Nice work, it just need some small improvements.
| def get_all(self, conditions: dict = {}) -> list: | ||
| conditions.update({"owner_id": self.current_user_id()}) | ||
|
|
||
| if 'month' and 'year' in conditions: |
Contributor
There was a problem hiding this comment.
Too much logic for a single function don't you think? Clean code my friend.
Angeluz-07
force-pushed
the
feature/get-time-entries-per-month-and-year#106
branch
from
9a71d4a to
f877e0a
Compare
Angeluz-07
force-pushed
the
feature/get-time-entries-per-month-and-year#106
branch
from
02f7899 to
e903313
Compare
Angeluz-07
force-pushed
the
feature/get-time-entries-per-month-and-year#106
branch
from
e903313 to
ff4a4d6
Compare
EliuX
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106