Skip to content

fix: #114 description should be optional #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enriquezrene merged 2 commits into from
Apr 27, 2020
Merged

fix: #114 description should be optional #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
627dd67
fix: #114 description should be optional
enriquezrene Apr 27, 2020
d31cfc9
fix: #114 marking description fields as optional on different namespaces
enriquezrene Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions time_tracker_api/activities/activities_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from flask_restplus._http import HTTPStatus

from time_tracker_api.activities.activities_model import create_dao
from time_tracker_api.api import common_fields, api, remove_required_constraint
from time_tracker_api.api import common_fields, api, remove_required_constraint, NullableString

faker = Faker()

Expand All @@ -18,7 +18,7 @@
description='Canonical name of the activity',
example=faker.word(['Development', 'Training']),
),
'description': fields.String(
'description': NullableString(
title='Description',
required=False,
description='Comments about the activity',
Expand Down
4 changes: 2 additions & 2 deletions time_tracker_api/customers/customers_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from flask_restplus import Resource, fields
from flask_restplus._http import HTTPStatus

from time_tracker_api.api import common_fields, api, remove_required_constraint
from time_tracker_api.api import common_fields, api, remove_required_constraint, NullableString
from time_tracker_api.customers.customers_model import create_dao

faker = Faker()
Expand All @@ -18,7 +18,7 @@
description='Name of the customer',
example=faker.company(),
),
'description': fields.String(
'description': NullableString(
title='Description',
required=False,
max_length=250,
Expand Down
5 changes: 3 additions & 2 deletions time_tracker_api/project_types/project_types_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
from flask_restplus import Resource, fields
from flask_restplus._http import HTTPStatus

from time_tracker_api.api import common_fields, create_attributes_filter, api, UUID, remove_required_constraint
from time_tracker_api.api import common_fields, create_attributes_filter, api, UUID, remove_required_constraint, \
NullableString
from time_tracker_api.project_types.project_types_model import create_dao

faker = Faker()
Expand All @@ -18,7 +19,7 @@
description='Name of the project type',
example=faker.random_element(["Customer", "Training", "Internal"]),
),
'description': fields.String(
'description': NullableString(
title='Description',
required=False,
max_length=250,
Expand Down
5 changes: 3 additions & 2 deletions time_tracker_api/projects/projects_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
from flask_restplus import Resource, fields
from flask_restplus._http import HTTPStatus

from time_tracker_api.api import common_fields, create_attributes_filter, UUID, api, remove_required_constraint
from time_tracker_api.api import common_fields, create_attributes_filter, UUID, api, remove_required_constraint, \
NullableString
from time_tracker_api.projects.projects_model import create_dao

faker = Faker()
Expand All @@ -18,7 +19,7 @@
description='Name of the project',
example=faker.company(),
),
'description': fields.String(
'description': NullableString(
title='Description',
required=False,
max_length=250,
Expand Down
2 changes: 1 addition & 1 deletion time_tracker_api/time_entries/time_entries_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
description='The id of the selected activity',
example=faker.uuid4(),
),
'description': fields.String(
'description': NullableString(
title='Comments',
required=False,
description='Comments about the time entry',
Expand Down