Close #107 Allow removing id by specifying null #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquezrene
approved these changes
Apr 24, 2020
EliuX
force-pushed
the
feature/allow-null-id-fields#107
branch
from
8aca6cb to
32a80b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows deleting optional ids by specifying
nullas value. Before that, this was not possible because a string was expected.In addition, based on a request made by @enriquezrene , I allowed the
UUIDfields to match an empty string and before saving I matched in theon_createandon_updatemethods of the Cosmos DB repository whether an attribute was an empty text. If so, that value would be replaced by anullvalue.