Skip to content

Commit 9b333e2

Browse files
committed
fix: TT-403 remove method POST
1 parent da5929d commit 9b333e2

File tree

15 files changed

+0
-169
lines changed

15 files changed

+0
-169
lines changed

V2/serverless.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,6 @@ functions:
7777
route: activities/
7878
authLevel: anonymous
7979

80-
create_time_entry:
81-
handler: time_tracker/time_entries/interface.create_time_entry
82-
events:
83-
- http: true
84-
x-azure-settings:
85-
methods:
86-
- POST
87-
route: time-entries/
88-
authLevel: anonymous
89-
9080
delete_time_entry:
9181
handler: time_tracker/time_entries/interface.delete_time_entry
9282
events:

V2/tests/api/azure/time_entry_azure_endpoints_test.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,6 @@
77
TIME_ENTRY_URL = "/api/time-entries/"
88

99

10-
def test__time_entry_azure_endpoint__creates_an_time_entry__when_time_entry_has_all_attributes(
11-
create_temp_time_entries, time_entry_factory
12-
):
13-
time_entries_json, tmp_directory = create_temp_time_entries
14-
time_entries._create_time_entry._JSON_PATH = tmp_directory
15-
16-
time_entry_body = time_entry_factory(None).__dict__
17-
body = json.dumps(time_entry_body).encode("utf-8")
18-
req = func.HttpRequest(
19-
method="POST",
20-
body=body,
21-
url=TIME_ENTRY_URL,
22-
)
23-
24-
response = time_entries.create_time_entry(req)
25-
time_entry_json_data = response.get_body()
26-
assert response.status_code == 201
27-
assert time_entry_json_data == body
28-
29-
3010
def test__delete_time_entries_azure_endpoint__returns_an_time_entry_with_true_deleted__when_its_id_is_found(
3111
create_temp_time_entries,
3212
):

V2/tests/integration/daos/time_entries_dao.test.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,6 @@ def _creator(time_entries):
1818
return _creator
1919

2020

21-
def test_create_time_entry__returns_an_time_entry_dto__when_create_an_time_entry_that_matches_attributes(
22-
create_fake_time_entries, time_entry_factory
23-
):
24-
create_fake_time_entries([])
25-
26-
time_entries_json_dao = TimeEntriesJsonDao(Faker().file_path())
27-
time_entry_data = time_entry_factory()
28-
result = time_entries_json_dao.create(time_entry_data.__dict__)
29-
assert result == TimeEntry(**time_entry_data)
30-
31-
3221
def test_delete__returns_an_time_entry_with_true_deleted__when_an_time_entry_matching_its_id_is_found(
3322
create_fake_time_entries, time_entry_factory
3423
):

V2/tests/unit/services/time_entry_service_test.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,6 @@
33
from time_tracker.time_entries._domain import TimeEntryService
44

55

6-
def test__create_time_entries__uses_the_time_entry_dao__to_create_an_time_entry(mocker):
7-
expected_time_entry = mocker.Mock()
8-
time_entry_dao = mocker.Mock(
9-
create=mocker.Mock(return_value=expected_time_entry)
10-
)
11-
time_entry_service = TimeEntryService(time_entry_dao)
12-
13-
actual_time_entry = time_entry_service.create(Faker().pydict())
14-
15-
assert time_entry_dao.create.called
16-
assert expected_time_entry == actual_time_entry
17-
18-
196
def test__delete_time_entry__uses_the_time_entry_dao__to_change_time_entry_deleted(
207
mocker,
218
):

V2/tests/unit/use_cases/time_entries_use_case_test.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,6 @@
44
from time_tracker.time_entries._domain import _use_cases
55

66

7-
def test__create_time_entry_function__uses_the_time_entries_service__to_create_time_entry(
8-
mocker: MockFixture, time_entry_factory
9-
):
10-
expected_time_entry = mocker.Mock()
11-
time_entry_service = mocker.Mock(
12-
create=mocker.Mock(return_value=expected_time_entry)
13-
)
14-
15-
time_entry_use_case = _use_cases.CreateTimeEntryUseCase(time_entry_service)
16-
actual_time_entry = time_entry_use_case.create_time_entry(time_entry_factory())
17-
18-
assert time_entry_service.create.called
19-
assert expected_time_entry == actual_time_entry
20-
21-
227
def test__delete_time_entry_function__uses_the_time_entry_service__to_change_time_entry_deleted(
238
mocker: MockFixture,
249
):
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# flake8: noqa
2-
from ._time_entries import create_time_entry
32
from ._time_entries import delete_time_entry
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# flake8: noqa
2-
from ._create_time_entry import create_time_entry
32
from ._delete_time_entry import delete_time_entry

V2/time_tracker/time_entries/_application/_time_entries/_create_time_entry.py

Lines changed: 0 additions & 66 deletions
This file was deleted.

V2/time_tracker/time_entries/_domain/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@
33
from ._persistence_contracts import TimeEntriesDao
44
from ._services import TimeEntryService
55
from ._use_cases import (
6-
CreateTimeEntryUseCase,
76
DeleteTimeEntryUseCase
87
)

V2/time_tracker/time_entries/_domain/_persistence_contracts/_time_entries_dao.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44

55

66
class TimeEntriesDao(abc.ABC):
7-
@abc.abstractmethod
8-
def create(self, time_entry_data: dict) -> TimeEntry:
9-
pass
10-
117
@abc.abstractmethod
128
def delete(self, id: int) -> TimeEntry:
139
pass

0 commit comments

Comments
 (0)