Skip to content

Commit da5929d

Browse files
committed
fix: TT-403 validation of id as integer
1 parent d5caf06 commit da5929d

File tree

6 files changed

+6
-42
lines changed

6 files changed

+6
-42
lines changed

V2/tests/api/azure/time_entry_azure_endpoints_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test__time_entry_azure_endpoint__creates_an_time_entry__when_time_entry_has_
2727
assert time_entry_json_data == body
2828

2929

30-
def test__time_entry_azure_endpoint__returns_an_time_entry_with_true_deleted__when_an_time_entry_matching_its_id_is_found(
30+
def test__delete_time_entries_azure_endpoint__returns_an_time_entry_with_true_deleted__when_its_id_is_found(
3131
create_temp_time_entries,
3232
):
3333
time_entries_json, tmp_directory = create_temp_time_entries
@@ -61,4 +61,4 @@ def test__delete_time_entries_azure_endpoint__returns_a_status_code_400__when_ti
6161
response = time_entries.delete_time_entry(req)
6262

6363
assert response.status_code == 400
64-
assert response.get_body() == b'Invalid Format ID'
64+
assert response.get_body() == b'Invalid Format ID'

V2/tests/integration/daos/time_entries_dao.test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def test_delete__returns_an_time_entry_with_true_deleted__when_an_time_entry_mat
4242
time_entry_dto = time_entries[0]
4343
result = time_entries_json_dao.delete(time_entry_dto.id)
4444

45-
assert result.deleted == True
45+
assert result.deleted is True
4646

4747

4848
def test_delete__returns_none__when_no_time_entry_matching_its_id_is_found(

V2/tests/unit/services/time_entry_service_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ def test__delete_time_entry__uses_the_time_entry_dao__to_change_time_entry_delet
2828
deleted_time_entry = time_entry_service.delete(Faker().pyint())
2929

3030
assert time_entry_dao.delete.called
31-
assert expected_time_entry == deleted_time_entry
31+
assert expected_time_entry == deleted_time_entry

V2/tests/unit/use_cases/time_entries_use_case_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ def test__delete_time_entry_function__uses_the_time_entry_service__to_change_tim
2929
deleted_time_entry = time_entry_use_case.delete_time_entry(Faker().pyint())
3030

3131
assert time_entry_service.delete.called
32-
assert expected_time_entry == deleted_time_entry
32+
assert expected_time_entry == deleted_time_entry

V2/time_tracker/time_entries/_application/_time_entries/_delete_time_entry.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,3 @@ def delete_time_entry(req: func.HttpRequest) -> func.HttpResponse:
3838
status_code=400,
3939
mimetype="application/json"
4040
)
41-
Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1 @@
1-
[
2-
{
3-
"id": 1,
4-
"start_date": "12/07/2021",
5-
"owner_id": 2,
6-
"description": "Review system of Time Tracker",
7-
"activity_id": 2,
8-
"uri": "http://time_tracker.com",
9-
"technologies": [
10-
"git",
11-
"jira",
12-
"python"
13-
],
14-
"end_date": "12/07/2021",
15-
"deleted": false,
16-
"timezone_offset": "300",
17-
"project_id": 1
18-
},
19-
{
20-
"id": 2,
21-
"start_date": "12/07/2021",
22-
"owner_id": 2,
23-
"description": "Review system of doors in the ioet office Loja, change the current raspberry pi ",
24-
"activity_id": 2,
25-
"uri": null,
26-
"technologies": [
27-
"git",
28-
"jira",
29-
"python"
30-
],
31-
"end_date": "12/07/2021",
32-
"deleted": false,
33-
"timezone_offset": "300",
34-
"project_id": 1
35-
}
36-
]
1+
[{"id": 1, "start_date": "12/07/2021", "owner_id": 2, "description": "Review system of Time Tracker", "activity_id": 2, "uri": "http://time_tracker.com", "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": true, "timezone_offset": "300", "project_id": 1}, {"id": 2, "start_date": "12/07/2021", "owner_id": 2, "description": "Review system of doors in the ioet office Loja, change the current raspberry pi ", "activity_id": 2, "uri": null, "technologies": ["git", "jira", "python"], "end_date": "12/07/2021", "deleted": false, "timezone_offset": "300", "project_id": 1}]

0 commit comments

Comments
 (0)