Skip to content

Commit 9aca374

Browse files
PabloPablo
authored andcommitted
fix: TT-220 code adjustments
1 parent ed1597d commit 9aca374

File tree

4 files changed

+10
-16
lines changed

4 files changed

+10
-16
lines changed

time_tracker_api/activities/activities_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def find_all_with_id_in_list(
8989
def find_all(
9090
self,
9191
event_context: EventContext,
92-
conditions: dict = None,
92+
conditions,
9393
visible_only=True,
9494
mapper: Callable = None,
9595
max_count=None,

time_tracker_api/projects/projects_model.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,12 @@ def __init__(self):
7171
def find_all(
7272
self,
7373
event_context: EventContext,
74-
conditions: dict = None,
74+
conditions,
7575
visible_only=True,
7676
mapper: Callable = None,
7777
project_ids: List[str] = None,
7878
customer_ids: List[str] = None,
7979
):
80-
params = self.generate_params(conditions) if conditions else []
81-
8280
query_builder = (
8381
CosmosDBQueryBuilder()
8482
.add_sql_where_equal_condition(conditions)
@@ -89,6 +87,7 @@ def find_all(
8987
)
9088
query_str = query_builder.get_query()
9189
tenant_id_value = self.find_partition_key_value(event_context)
90+
params = query_builder.get_parameters()
9291
result = self.container.query_items(
9392
query=query_str,
9493
parameters=params,

time_tracker_api/time_entries/time_entries_repository.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -152,19 +152,7 @@ def find_all(
152152
mapper: Callable = None,
153153
):
154154
max_count = self.get_page_size_or(max_count)
155-
156-
params = [
157-
{"name": "@offset", "value": offset},
158-
{"name": "@limit", "value": max_count},
159-
]
160-
161155
date_range = date_range if date_range else {}
162-
date_range_params = (
163-
self.generate_params(date_range) if date_range else []
164-
)
165-
166-
params.extend(self.generate_params(conditions) if conditions else [])
167-
params.extend(date_range_params)
168156

169157
query_builder = (
170158
CosmosDBQueryBuilder()
@@ -180,6 +168,7 @@ def find_all(
180168
)
181169

182170
query_str = query_builder.get_query()
171+
params = query_builder.get_parameters()
183172
tenant_id_value = self.find_partition_key_value(event_context)
184173
result = self.container.query_items(
185174
query=query_str,

utils/query_builder.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,12 @@ def __build_order_by(self):
109109

110110
def __build_date_range(self):
111111
if self.date_range:
112+
self.parameters.append(
113+
{'name': '@start_date', 'value': self.date_range['start_date']}
114+
)
115+
self.parameters.append(
116+
{'name': '@end_date', 'value': self.date_range['end_date']}
117+
)
112118
and_keyword = "AND " if len(self.where_conditions) > 0 else ""
113119
return f"{and_keyword}((c.start_date BETWEEN @start_date AND @end_date) OR (c.end_date BETWEEN @start_date AND @end_date))"
114120
else:

0 commit comments

Comments
 (0)