fix: TT-220 code adjustments

Author: Pablo

commons/data_access_layer/cosmos_db.py

@@ -206,13 +206,9 @@ def attach_context(data: dict, event_context: EventContext):
             "session_id": event_context.session_id,
         }
 
-    @staticmethod
-    def validate_date_range(date_range: dict) -> bool:
-        return 'start_date' and 'end_date' in date_range
-
     @staticmethod
     def create_sql_date_range_filter(date_range: dict) -> str:
-        if CosmosDBRepository.validate_date_range(date_range):
+        if 'start_date' in date_range and 'end_date' in date_range:
             return """
                 AND ((c.start_date BETWEEN @start_date AND @end_date) OR
                  (c.end_date BETWEEN @start_date AND @end_date))
@@ -255,10 +251,10 @@ def find_all(
         event_context: EventContext,
         conditions: dict = None,
         visible_only=True,
+        mapper: Callable = None,
         max_count=None,
         offset=0,
         date_range: dict = None,
-        mapper: Callable = None,
     ):
         conditions = conditions if conditions else {}
         partition_key_value = self.find_partition_key_value(event_context)

tests/time_tracker_api/projects/projects_model_test.py

@@ -29,7 +29,10 @@ def test_find_all_projects_new_version(
     project_repository.container.query_items = query_items_mock
 
     result = project_repository.find_all(
-        event_context, {"customer_id": "1"}, ['id'], ['customer_id']
+        event_context=event_context,
+        conditions={"customer_id": "1"},
+        project_ids=['id'],
+        customer_ids=['customer_id'],
     )
     find_partition_key_value_mock.assert_called_once()
     assert len(result) == 1

time_tracker_api/activities/activities_model.py

@@ -91,10 +91,10 @@ def find_all(
         event_context: EventContext,
         conditions: dict = None,
         visible_only=True,
+        mapper: Callable = None,
         max_count=None,
         offset=0,
         activities_id: List = None,
-        mapper: Callable = None,
     ):
         query_builder = (
             CosmosDBQueryBuilder()

time_tracker_api/projects/projects_model.py

@@ -73,9 +73,9 @@ def find_all(
         event_context: EventContext,
         conditions: dict = None,
         visible_only=True,
+        mapper: Callable = None,
         project_ids: List[str] = None,
         customer_ids: List[str] = None,
-        mapper: Callable = None,
     ):
         params = self.generate_params(conditions) if conditions else []
 
@@ -117,7 +117,6 @@ def get_all(
             max_count=kwargs.get('max_count', None)
         )
 
-        # TODO: evaluate another approach in order that memory filtering will be make in Database instead
         customers_id = [
             customer.id
             for customer in customers