-
Notifications
You must be signed in to change notification settings - Fork 0
feat: TT-153 Sign Up Validation Function #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this functionality should be implemented as an Azure function. Why not making it part of the API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep is a good idea, I created as azure function because the sign-up validation was part of the azure scope and azure provides some examples with azure function to validate the sign-up process with the API Connector tool, but I can create a ticket to migrate this function to the API, because now is implemented in the user flow.
|
|
||
| context.log("Validation: ", allowedDomains.includes(domain.toLowerCase())); | ||
| // Check that the domain of the email is from a specific other tenant | ||
| if (!allowedDomains.includes(domain.toLowerCase())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're only looking for ioet.com as a valid domain?
I don't think so, you should find a way to make sure the token is correct and it is not expired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point we didn't have the token yet.
Since is before the user is created, and it's validating the email with which the user is trying to log in with the google provider.
diegotony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.