Skip to content

10 avoid mentioning same person twice #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2020
Merged

10 avoid mentioning same person twice #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbcad2c
WIP avoid mentioning same person twice
enriquezrene Nov 20, 2020
ec57b65
fix: updating the query to ignore deleted entries
enriquezrene Nov 20, 2020
b8be91c
fix: adding env vars info as part of the readme file
enriquezrene Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: updating the query to ignore deleted entries
  • Loading branch information
@enriquezrene
enriquezrene committed Nov 20, 2020
commit ec57b654e9c74fff2cf2558614c2465a372ad433
5 changes: 1 addition & 4 deletions AutomaticClockOuts/clock_out.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ const doClockOut = async (context) => {
await Promise.all(entries.map(async (timeEntryAsJson) => {
const timeEntry = new TimeEntry(timeEntryAsJson)
if (timeEntry.needsToBeClockedOut()) {
const userToClockOut = findUser(users, timeEntry.timeEntry.owner_id);
if(!userToClockOut.includes(userToClockOut)){
usersWithClockOut.push(userToClockOut)
}
usersWithClockOut.push(findUser(users, timeEntry.timeEntry.owner_id));
timeEntryAsJson.end_date = timeEntry.getTimeToClockOut()
await container.item(timeEntryAsJson.id, timeEntryAsJson.tenant_id).replace(timeEntryAsJson)
totalClockOutsExecuted++
Expand Down
7 changes: 3 additions & 4 deletions AutomaticClockOuts/time_entry_dao.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
class TimeEntryDao {

CONTAINER_ID = 'time_entry';

constructor(database) {
this.container = database.container(this.CONTAINER_ID);
const CONTAINER_ID = 'time_entry';
this.container = database.container(CONTAINER_ID);
}

async getEntriesWithNoEndDate () {
const QUERY_WITHOUT_END_DATE =
"SELECT * FROM c WHERE (NOT IS_DEFINED(c.end_date) OR IS_NULL(c.end_date) = true) AND IS_DEFINED(c.start_date)";
"SELECT * FROM c WHERE (NOT IS_DEFINED(c.end_date) OR IS_NULL(c.end_date) = true) AND IS_DEFINED(c.start_date) AND (NOT IS_DEFINED(c.deleted) OR IS_NULL(c.deleted) = true)";
return this.container.items
.query({query: QUERY_WITHOUT_END_DATE})
.fetchAll();
Expand Down