Skip to content

fix: Milestones date sorting out of order #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 2 commits into from
Nov 7, 2025
Merged

fix: Milestones date sorting out of order #9868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e82b6
Add hidden YYYY-MM-DD field to sort
evyncke Nov 3, 2025
ded492d
Also hide for ARIA readers
evyncke Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ietf/templates/group/milestones.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h2 class="my-3">
<table class="table table-sm table-striped tablesorter">
<thead>
<tr>
<th class="col-2" scope="col"{% if group.uses_milestone_dates %} data-sort="num"{% endif %}>
<th class="col-2" scope="col"{% if group.uses_milestone_dates %} data-sort="num"{% endif %} data-default-sort="asc">
Copy link
Copy Markdown
Member

@rjsparks rjsparks Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not inside the if?

Copy link
Copy Markdown
Collaborator Author

@evyncke evyncke Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to also sort by default when a date format is not used

{% if group.uses_milestone_dates %}
Date
{% else %}
Expand All @@ -39,7 +39,7 @@ <h2 class="my-3">
<span class="badge rounded-pill {% if milestone.resolved|slugify == 'done' %}text-bg-success{% else %}text-bg-warning{% endif %}">{{ milestone.resolved|title }}</span>
{% else %}
{% if group.uses_milestone_dates %}
{{ milestone.due|date:"M Y" }}
<span class="d-none" aria-hidden="true">{{ milestone.due }}</span>{{ milestone.due|date:"M Y" }}
{% else %}
{% if forloop.first %}Last{% endif %}
{% if forloop.last %}Next{% endif %}
Expand Down
Loading