Skip to content

feat: allow editing call for adoption messages#9702

Merged
rjsparks merged 3 commits into
ietf-tools:feat/issuewglcfrom
rjsparks:issueadoptcall
Oct 15, 2025
Merged

feat: allow editing call for adoption messages#9702
rjsparks merged 3 commits into
ietf-tools:feat/issuewglcfrom
rjsparks:issueadoptcall

Conversation

@rjsparks

@rjsparks rjsparks commented Oct 10, 2025

Copy link
Copy Markdown
Member

No description provided.

@rjsparks rjsparks changed the title feat: (WIP) sketch of workflow changes to allow editing call for adop… feat: allow editing call for adoption messages Oct 10, 2025
@rjsparks rjsparks marked this pull request as draft October 10, 2025 21:34
@rjsparks

Copy link
Copy Markdown
Member Author

Still WIP - several other workflows need intervention.

@jennifer-richards

Copy link
Copy Markdown
Member

(approved what's here if you want to do the additional work in a separate PR, but feel free to continue on this one if you prefer)

@rjsparks rjsparks marked this pull request as ready for review October 14, 2025 16:09
Comment thread ietf/doc/templatetags/ietf_filters.py Outdated
def can_issue_ietf_call_for_adoption(doc):
return all(
[
doc.stream_id in ["ietf", None],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the doc.stream_id is None case needed to allow calls for adopting individual submissions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's why it had wandered in and back out of this code - but no, it doesn't. The workflow won't go through the view that uses this filter when working with an individual document. The filter's name may need updating to not be an attractive nuisance. We could change it to can_issue_ietf_call_for_adoption_of_doc_already_in_ietf_stream but...

@rjsparks rjsparks Oct 15, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I compared these workflows to a moog patch panel earlier - This is a bandaid on a bandaid to work around the original stream state editing view doing so much of its work by side-effect.

@rjsparks rjsparks merged commit 2fab99d into ietf-tools:feat/issuewglc Oct 15, 2025
2 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 19, 2025
@rjsparks rjsparks deleted the issueadoptcall branch December 5, 2025 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants