Skip to content

feat: use rfcauthors for nomcom eligibility#9629

Merged
jennifer-richards merged 13 commits intoietf-tools:feat/rfcauthorsfrom
jennifer-richards:rfcauthor-eligibility
Nov 3, 2025
Merged

feat: use rfcauthors for nomcom eligibility#9629
jennifer-richards merged 13 commits intoietf-tools:feat/rfcauthorsfrom
jennifer-richards:rfcauthor-eligibility

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Refactors computation of the authorship path for nomcom eligibility to fix up some stale logic. Uses RfcAuthor records instead of DocumentAuthor for RFCs that have the former.

Copy link
Copy Markdown
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work best if the creation of rfcauthors via merged rfc and datatracker data preserves datatracker person links for authors on the last draft that remained authors on the RFC. I believe that merge has that property, but if it doesn't we should look to fix it.

@jennifer-richards
Copy link
Copy Markdown
Member Author

This will work best if the creation of rfcauthors via merged rfc and datatracker data preserves datatracker person links for authors on the last draft that remained authors on the RFC. I believe that merge has that property, but if it doesn't we should look to fix it.

Assuming you mean the place that DocumentAuthor records are created for the Document(type="rfc"), then yes, those are exact copies of the records that were tied to the final datatracker draft at the time of publication.

When we start creating RfcAuthor data we'll need to be careful to maintain the Person links, but afaik we have not done that yet. If I've missed something, please let me know.

@jennifer-richards jennifer-richards marked this pull request as ready for review September 30, 2025 19:49
@rjsparks
Copy link
Copy Markdown
Member

rjsparks commented Oct 1, 2025

When we start creating RfcAuthor data we'll need to be careful to maintain the Person links

Is what I was talking about. I believe the merge we're doing creating purple's database has this property - it is intended to, but we should verify that nothing is perturbing it.

Attempted to limit to drafts literally in the queue, but was not a
valid check when looking back in time. As a practical matter, the test
is not necessary.
@jennifer-richards jennifer-richards merged commit 96a73c8 into ietf-tools:feat/rfcauthors Nov 3, 2025
2 checks passed
@jennifer-richards jennifer-richards deleted the rfcauthor-eligibility branch November 3, 2025 16:38
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants