refactor: move session request tool to ietf.meeting and restyle#9617
Merged
jennifer-richards merged 7 commits intoietf-tools:feat/sreqfrom Oct 7, 2025
Merged
refactor: move session request tool to ietf.meeting and restyle#9617jennifer-richards merged 7 commits intoietf-tools:feat/sreqfrom
jennifer-richards merged 7 commits intoietf-tools:feat/sreqfrom
Conversation
…tch standard Datatracker
rjsparks
requested changes
Sep 29, 2025
Member
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
Please review and update all the copyright lines for modified files.
rjsparks
previously approved these changes
Sep 30, 2025
jennifer-richards
requested changes
Oct 2, 2025
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Looks ok. I think a couple of js files should be renamed to avoid confusion and have a question about whether the single redirect for the main sreq page is adequate.
Not for this PR, but several of these views have side effects on GET requests. That's an anti-pattern and we should refactor in the nearish future to move these to POSTs instead.
Member
|
Merging to a feature branch for sandbox deployment. Test failures are coverage reduction only, so ignoring. |
rjsparks
added a commit
that referenced
this pull request
Oct 10, 2025
* refactor: move session request tool to ietf.meeting and restyle (#9617) * refactor: move session request tool to ietf.meeting and restyle to match standard Datatracker * fix: add redirect for old session request url * fix: move stripe javascript to js file * fix: update copyright lines for modified files * fix: rename javascripts and expand redirects * fix: don't show inactive constraints label when there are none (#9680) * chore: remove unused utility * fix: add test for secr main menu page (#9693) * fix: don't show inactive constraints label when there are none * fix: add test for secr main menu page --------- Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org> Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restyle to match standard Datatracker