Skip to content

fix: escape nulls in XML api responses#9283

Merged
rjsparks merged 5 commits intoietf-tools:mainfrom
jennifer-richards:tasty-null-pie
Aug 4, 2025
Merged

fix: escape nulls in XML api responses#9283
rjsparks merged 5 commits intoietf-tools:mainfrom
jennifer-richards:tasty-null-pie

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Replaces null characters with \0 in tastypie XML responses. This should stanch the flow of 500 errors we get when fuzzers hit tastypie endpoints. (Tastypie is correctly rejecting the requests with the garbage, then hitting an exception when it tries to respond with an XML format error that includes the garbage, so these errors are pure noise.)

Less likely to lead to null injection down the road
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.74%. Comparing base (ea8377d) to head (163d545).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9283      +/-   ##
==========================================
- Coverage   88.74%   88.74%   -0.01%     
==========================================
  Files         320      320              
  Lines       41674    41685      +11     
==========================================
+ Hits        36985    36992       +7     
- Misses       4689     4693       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks rjsparks merged commit 827f4e7 into ietf-tools:main Aug 4, 2025
10 checks passed
@jennifer-richards jennifer-richards deleted the tasty-null-pie branch August 4, 2025 18:11
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants