Skip to content

feat: Sort IESG and IAB Statements Pages with Active Statements at the Top#9198

Merged
rjsparks merged 4 commits into
ietf-tools:mainfrom
evyncke:fix-9058
Jul 23, 2025
Merged

feat: Sort IESG and IAB Statements Pages with Active Statements at the Top#9198
rjsparks merged 4 commits into
ietf-tools:mainfrom
evyncke:fix-9058

Conversation

@evyncke

@evyncke evyncke commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator

Address issue #9058

Remaining caveat: it is sorted by statement.state but currently only "active" and "replaced" whose alphabetical order matches the requested feature. If other states are introduced (e.g., "historic"), then the order wont't be so perfect.

@codecov

codecov Bot commented Jul 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (e16d568) to head (f05df58).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9198      +/-   ##
==========================================
+ Coverage   88.72%   88.76%   +0.03%     
==========================================
  Files         321      320       -1     
  Lines       41851    41648     -203     
==========================================
- Hits        37134    36967     -167     
+ Misses       4717     4681      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rjsparks
rjsparks previously approved these changes Jul 21, 2025
@rjsparks

Copy link
Copy Markdown
Member

It's unlikely some other status would come in alphabetically lower than active, but if it ever did, we could build a sort that deals with it.

@evyncke

evyncke commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator Author

This is also my thinking, let's not overdo it right now.

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

Comment thread ietf/templates/group/statements.html Outdated
@rjsparks rjsparks merged commit 0e2df84 into ietf-tools:main Jul 23, 2025
10 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants