fix: Add Reviews history page to review teams group page. (fixes #9190)#9191
Merged
Conversation
Member
|
Moving this to draft per in-person discussion with Tero |
Member
|
On the first test run, there is only one real failure (mypy). The second failure at is a transient. For the first error, try just before using it in the code rather than importing HistoricalReviewAssignment. |
Member
|
The new view and template are missing test coverage. |
Fixed html to validate, moved sort text to data-text from comments. Added test cases. fixes ietf-tools#9190
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9191 +/- ##
========================================
Coverage 88.74% 88.75%
========================================
Files 321 320 -1
Lines 41853 41674 -179
========================================
- Hits 37144 36989 -155
+ Misses 4709 4685 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Jul 25, 2025
jennifer-richards
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the Reviews history page for the review teams.