Skip to content

refactor: Separate demo logic#8937

Merged
jennifer-richards merged 2 commits into
ietf-tools:feat/rpc-apifrom
kesara:refactor/demo
May 29, 2025
Merged

refactor: Separate demo logic#8937
jennifer-richards merged 2 commits into
ietf-tools:feat/rpc-apifrom
kesara:refactor/demo

Conversation

@kesara

@kesara kesara commented May 28, 2025

Copy link
Copy Markdown
Member

No description provided.

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Suggestion inline to also skip the demo endpoints in test - thoughts?

Comment thread ietf/api/urls_rpc.py Outdated
@kesara

kesara commented May 29, 2025

Copy link
Copy Markdown
Member Author

Looks great! Suggestion inline to also skip the demo endpoints in test - thoughts?

Yeah, I'll change the logic to skip test SERVER_MODE.

@jennifer-richards
jennifer-richards merged commit 9f718a3 into ietf-tools:feat/rpc-api May 29, 2025
@kesara
kesara deleted the refactor/demo branch May 29, 2025 20:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants