fix: put draft name first in subject of review email#8830
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Apr 25, 2025
Merged
fix: put draft name first in subject of review email#8830rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
Fixes ietf-tools#5946. This is the minimal fix; other optimisations might be possible, but this gets the job done for the common case -- people scanning for drafts they're interested in.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8830 +/- ##
==========================================
- Coverage 88.81% 88.79% -0.02%
==========================================
Files 314 314
Lines 41430 41401 -29
==========================================
- Hits 36795 36763 -32
- Misses 4635 4638 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
changed the title
rjsparks
approved these changes
Apr 25, 2025
Member
|
I suspect we'll get feedback from the review community when this is deployed, but I don't think there's a better way to get that feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5946.
This is the minimal fix; other optimisations might be possible, but this gets the job done for the common case -- people scanning for drafts they're interested in.