feat: highlight unexpected state in AD dashboard#8738
Merged
rjsparks merged 3 commits intoMar 27, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8738 +/- ##
==========================================
- Coverage 88.88% 88.81% -0.07%
==========================================
Files 312 314 +2
Lines 40891 41252 +361
==========================================
+ Hits 36345 36637 +292
- Misses 4546 4615 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
requested changes
Mar 27, 2025
rjsparks
left a comment
rjsparks
left a comment
Member
There was a problem hiding this comment.
Looking good - a couple of minor changes suggested
Comment on lines
+493
to
+495
| return not ( | ||
| (draft_iesg_state and draft_iesg_state.slug == "idexists") | ||
| or (draft_stream_state and draft_stream_state.slug == "sub-pub") |
Member
There was a problem hiding this comment.
This is still a bit of a logic puzzle for future readers. I suggest this as a clearer way to state it:
return draft_iesg_state.slug != "idexists" and draft_stream_state is not None and draft_stream_state.slug != "sub-pub"
+/- black formatting
| ConflictReviewFactory, | ||
| BofreqFactory, | ||
| StatementFactory, | ||
| DocumentFactory, |
Member
There was a problem hiding this comment.
I think you should use WgDraftFactory rather than the bare DocumentFactory - it doesn't make sense to test this against non-ietf-stream documents.
rjsparks
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8550