Skip to content

fix(agenda): strikethrough cancelled and rescheduled events#8694

Merged
rjsparks merged 4 commits intoietf-tools:mainfrom
NGPixel:agenda-strikethrough
Mar 28, 2025
Merged

fix(agenda): strikethrough cancelled and rescheduled events#8694
rjsparks merged 4 commits intoietf-tools:mainfrom
NGPixel:agenda-strikethrough

Conversation

@NGPixel
Copy link
Copy Markdown
Member

@NGPixel NGPixel commented Mar 18, 2025

No description provided.

@NGPixel NGPixel requested a review from rjsparks March 18, 2025 03:42
rjsparks
rjsparks previously approved these changes Mar 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (70bf2ae) to head (5862533).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8694      +/-   ##
==========================================
- Coverage   88.88%   88.81%   -0.07%     
==========================================
  Files         312      314       +2     
  Lines       40891    41245     +354     
==========================================
+ Hits        36345    36631     +286     
- Misses       4546     4614      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rjsparks
rjsparks previously approved these changes Mar 21, 2025
Comment thread client/agenda/AgendaScheduleList.vue Outdated
rjsparks
rjsparks previously approved these changes Mar 21, 2025
@holloway
Copy link
Copy Markdown
Contributor

holloway commented Mar 21, 2025

I've had a proper look at this branch (rather than just commenting from the sidelines!) and it seems the underlying issue is still present in other badges like 'Proposed'...

Screenshot_2025-03-21_21-36-41

What we're seeing in that screenshot is the text overflowing the container (the grey background colour indicates the approx width of the container) and because it's a single word the browser's default behaviour is to let the text overflow.

It looks like .badge has a width of 30px which is the underlying issue. These classes are fighting over which one gets to set the width. So we could fix it by giving .is-cancelled a width of 10em (which wins CSS specificity due to a more specific class) but another way of fixing it would be to not specify widths at all.

If we remove the width/display:block from .badge, and any widths from badge-specific styles like .is-proposed/.is-cancelled then it looks like this,

Screenshot_2025-03-21_21-54-49

Note that without hardcoded widths the browser can fit the container to the text size automatically.

@rjsparks rjsparks merged commit aa2a321 into ietf-tools:main Mar 28, 2025
10 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants