fix(agenda): handle calendar view events that spread across multiple days#8685
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Mar 19, 2025
Merged
fix(agenda): handle calendar view events that spread across multiple days#8685rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8685 +/- ##
==========================================
- Coverage 88.88% 88.80% -0.09%
==========================================
Files 312 314 +2
Lines 40891 41243 +352
==========================================
+ Hits 36345 36624 +279
- Misses 4546 4619 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Would be nice if we had a set of tests that would track changes like this. |
rjsparks
approved these changes
Mar 17, 2025
Member
Author
|
We don't test the calendar component (other than opening the modal and validating the buttons around it) because it's an external library. |
jennifer-richards
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8682