Skip to content

chore: Add draft name to review-completed email - #8676

Merged
rjsparks merged 3 commits into
ietf-tools:mainfrom
richsalz:fix-7866
Mar 19, 2025
Merged

chore: Add draft name to review-completed email#8676
rjsparks merged 3 commits into
ietf-tools:mainfrom
richsalz:fix-7866

Conversation

@richsalz

Copy link
Copy Markdown
Collaborator

Fixes: #7866

@codecov

codecov Bot commented Mar 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (70bf2ae) to head (25ffdd7).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8676      +/-   ##
==========================================
- Coverage   88.88%   88.80%   -0.08%     
==========================================
  Files         312      314       +2     
  Lines       40891    41243     +352     
==========================================
+ Hits        36345    36626     +281     
- Misses       4546     4617      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit:

Comment thread ietf/templates/review/completed_review.txt Outdated
@rjsparks

Copy link
Copy Markdown
Member

I think I can simplify this - if so, will commit that simplification in a bit

@rjsparks

Copy link
Copy Markdown
Member

And on further review - the PR missed the aim of the issue - the issue was asking for the title of the draft, not the name.

@richsalz

Copy link
Copy Markdown
Collaborator Author

And on further review - the PR missed the aim of the issue - the issue was asking for the title of the draft, not the name.

Aargh. I blame jet-lag. :)

@rjsparks
rjsparks merged commit fde8136 into ietf-tools:main Mar 19, 2025
@pspacek

pspacek commented Mar 19, 2025

Copy link
Copy Markdown

Thank you very much!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add draft title in beginning of review email message

4 participants