fix: Clarify legacy description in RFC banner (#8424)#8670
Merged
Conversation
Contributor
Author
|
fixes #8424 by using the suggested text in the issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8670 +/- ##
==========================================
- Coverage 88.88% 88.80% -0.08%
==========================================
Files 312 314 +2
Lines 40891 41221 +330
==========================================
+ Hits 36345 36606 +261
- Misses 4546 4615 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
cc: @rdanyliw |
rjsparks
approved these changes
Mar 21, 2025
rjsparks
left a comment
rjsparks
left a comment
Member
There was a problem hiding this comment.
There's some repetition of the conditionals in the template that would be better handled as nested conditionals, but we'll improve it with a separate effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.