chore: get django out of the forwarded header business - #8634
Merged
Conversation
jennifer-richards
marked this pull request as ready for review
April 23, 2025 10:59
rjsparks
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will decide whether a request is using https based on
wsgi.url_scheme, as decided by gunicorn.This reduces the number of places we have to touch to declare that
X-Forwarded-Protois authoritative vs alternative headers. It's set for us at Cloudflare and it is configured to be respected in ourgunicorn.conf.py.When this goes to staging and production, a quick way to check that the configuration is correct is to retrieve
/api/openid/.well-known/openid-configuration/and confirm that the various URLs are allhttps://. If they'rehttp://, then something is misconfigured.Creating as a draft PR until after IETF-122