Skip to content

fix: more submission date feedback; refactor xml2rfc log capture#8621

Merged
rjsparks merged 9 commits intoietf-tools:mainfrom
jennifer-richards:more-date-bugs
Mar 3, 2025
Merged

fix: more submission date feedback; refactor xml2rfc log capture#8621
rjsparks merged 9 commits intoietf-tools:mainfrom
jennifer-richards:more-date-bugs

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Main goal: log helpful feedback on more (hopefully now all!) paths where a <date> fails parsing or interpretation.

Throws in some refactoring to centralize capture of the xml2rfc log output. This is done with the capture_xml2rfc_output context manager. A known side effect of the refactoring in 3529f14 is that xml2rfc.log.write_out and xml2rfc.log.write_err will be restored to their original streams after each call to render_missing_formats() instead of being left pointing at otherwise abandoned StringIO instances. I think that's a win, but wanted to call it out as a possibly non-obvious change.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (70bf2ae) to head (e61d78a).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
ietf/submit/utils.py 78.94% 8 Missing ⚠️
ietf/utils/xmldraft.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8621      +/-   ##
==========================================
- Coverage   88.88%   88.80%   -0.08%     
==========================================
  Files         312      314       +2     
  Lines       40891    41221     +330     
==========================================
+ Hits        36345    36606     +261     
- Misses       4546     4615      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@kesara kesara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rjsparks rjsparks merged commit cb8ef96 into ietf-tools:main Mar 3, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 7, 2025
@jennifer-richards jennifer-richards deleted the more-date-bugs branch April 3, 2025 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants