Skip to content

chore: ensure proper return type #8566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-richards merged 2 commits into from
Feb 20, 2025
Merged

chore: ensure proper return type #8566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b5c2f9
chore: ensure proper return type
rjsparks Feb 20, 2025
da25135
test: comment out (intentionally) failing assertion
jennifer-richards Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ietf/doc/storage_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ def exists_in_storage(kind: str, name: str) -> bool:
return store.exists_in_storage(kind, name)
except Exception as err:
log(f"Blobstore Error: Failed to test existence of {kind}:{name}: {repr(err)}")
else:
return False
return False


def remove_from_storage(kind: str, name: str, warn_if_missing: bool = True) -> None:
Expand Down
5 changes: 3 additions & 2 deletions ietf/doc/tests_status_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,8 +564,9 @@ def test_initial_submission(self):
ftp_filepath = Path(settings.FTP_DIR) / "status-changes" / basename
self.assertFalse(filepath.exists())
self.assertFalse(ftp_filepath.exists())
with self.assertRaises(FileNotFoundError):
retrieve_str("statchg",basename)
# TODO-BLOBSTORE: next assert is disabled because we currently suppress all exceptions
# with self.assertRaises(FileNotFoundError):
# retrieve_str("statchg",basename)
r = self.client.post(url,dict(content="Some initial review text\n",submit_response="1"))
self.assertEqual(r.status_code,302)
doc = Document.objects.get(name='status-change-imaginary-mid-review')
Expand Down