Skip to content

refactor: don't template inside <script>#8480

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
jennifer-richards:no-js-template
Jan 29, 2025
Merged

refactor: don't template inside <script>#8480
rjsparks merged 1 commit into
ietf-tools:mainfrom
jennifer-richards:no-js-template

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

Addresses the issue described here #8475 (comment)

(the quoting issues were non-issues, but it's really not a good practice to use Django templating in javascript)

This does not address the issue in that ticket, just the comment.

@codecov

codecov Bot commented Jan 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (a4eeae5) to head (099df4c).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8480   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         312      312           
  Lines       40886    40856   -30     
=======================================
- Hits        36308    36284   -24     
+ Misses       4578     4572    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
rjsparks merged commit d3bf0a3 into ietf-tools:main Jan 29, 2025
@jennifer-richards
jennifer-richards deleted the no-js-template branch January 30, 2025 00:57
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants