feat: retrieve single rfc, including text#8346
Merged
jennifer-richards merged 3 commits intoietf-tools:feat/rpc-apifrom Dec 19, 2024
Merged
feat: retrieve single rfc, including text#8346jennifer-richards merged 3 commits intoietf-tools:feat/rpc-apifrom
jennifer-richards merged 3 commits intoietf-tools:feat/rpc-apifrom
Conversation
Use RFC number instead of doc PK as id
rjsparks
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the stub of a retrieve action via GET of
/api/red/doc/<rfc number>/into a working endpoint. It replaces doc id with RFC number as a lookup attribute and stops exposing the doc ID through this interface.Adds a
textfield to the retrieve action that includes the plaintext format of the requested document when available. If not available, returns a null value instead.Per our discussion on Dec 17 about how we'll store / serve document contents, there's a fairly good chance we'll change that last part in the future. This gets data to the front end to serve in the short term though, which will allow progress on the front end while we're working out the storage details.