Skip to content

fix: homepage logo width#8338

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
NGPixel:fix-8308
Dec 17, 2024
Merged

fix: homepage logo width#8338
rjsparks merged 2 commits into
ietf-tools:mainfrom
NGPixel:fix-8308

Conversation

@NGPixel

@NGPixel NGPixel commented Dec 14, 2024

Copy link
Copy Markdown
Member

Fixes #8308

@NGPixel NGPixel requested a review from rjsparks December 14, 2024 05:58
@codecov

codecov Bot commented Dec 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (6b77807) to head (1871e2a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8338   +/-   ##
=======================================
  Coverage   88.72%   88.73%           
=======================================
  Files         310      312    +2     
  Lines       40882    40915   +33     
=======================================
+ Hits        36273    36305   +32     
- Misses       4609     4610    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread ietf/static/css/ietf.scss

// Helper to constrain the size of the main logo
.ietflogo {
width: 75%;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larseggert Where did this .75 originally come from?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. But that used to look correct with the old CSS. 🤷

Comment thread ietf/static/css/ietf.scss
@rjsparks rjsparks merged commit 171e50b into ietf-tools:main Dec 17, 2024
@NGPixel NGPixel deleted the fix-8308 branch December 17, 2024 20:08
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile view improvements

4 participants