Skip to content

refactor: separate concerns / rename notify_events#8328

Merged
rjsparks merged 5 commits into
ietf-tools:mainfrom
jennifer-richards:notify-events-receiver
Dec 12, 2024
Merged

refactor: separate concerns / rename notify_events#8328
rjsparks merged 5 commits into
ietf-tools:mainfrom
jennifer-richards:notify-events-receiver

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

Splits the signal receiver logic from the task queuing logic in a way that improves testability. Testing whether a notification email was sent is now just a simple mock to check whether ietf.community.models.notify_of_event() was called with the event.

@codecov

codecov Bot commented Dec 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (6b77807) to head (1f6c0f1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8328   +/-   ##
=======================================
  Coverage   88.72%   88.73%           
=======================================
  Files         310      312    +2     
  Lines       40882    40892   +10     
=======================================
+ Hits        36273    36285   +12     
+ Misses       4609     4607    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
rjsparks merged commit 70ab711 into ietf-tools:main Dec 12, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 16, 2024
@jennifer-richards
jennifer-richards deleted the notify-events-receiver branch December 18, 2024 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants