fix: disable raw/include in RST#8300
Merged
Merged
Conversation
kesara
approved these changes
Dec 5, 2024
kesara
left a comment
kesara
left a comment
Member
There was a problem hiding this comment.
LGTM
Another recommendation in Deploying Docutils Securely, is to lower the line_length_limit 1. Default value is 10 000. Not sure that can cause any issues.
Footnotes
rjsparks
approved these changes
Dec 5, 2024
Member
Author
I don't have any idea what a more reasonable limit would be. Given the access controls guarding places we accept user input to the RST processor and the hopefully limited lifespan of supporting RST, I think we can leave it as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.