fix: flaky playwright status tests#8267
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8267 +/- ##
==========================================
+ Coverage 88.94% 88.96% +0.01%
==========================================
Files 303 303
Lines 41284 41273 -11
==========================================
- Hits 36720 36718 -2
+ Misses 4564 4555 -9 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
holloway
marked this pull request as ready for review
November 24, 2024 04:59
rjsparks
approved these changes
Nov 25, 2024
NGPixel
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix the flaky playwright Status tests by increasing playwright timeout for Status from 5s to 15s
Over
1020 test runs on CI it passed every time. Did I just get lucky or does this fix it? 🤷Increasing the timeout doesn't seem to affect the overall playwright test running time in any noticable way in this statistically insignificant sample:

(spreadsheet)