Skip to content

fix: flaky playwright status tests#8267

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
holloway:fix-playwright-status-test
Nov 25, 2024
Merged

fix: flaky playwright status tests#8267
rjsparks merged 1 commit into
ietf-tools:mainfrom
holloway:fix-playwright-status-test

Conversation

@holloway

@holloway holloway commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

Attempts to fix the flaky playwright Status tests by increasing playwright timeout for Status from 5s to 15s

Over 10 20 test runs on CI it passed every time. Did I just get lucky or does this fix it? 🤷

Increasing the timeout doesn't seem to affect the overall playwright test running time in any noticable way in this statistically insignificant sample:
Screenshot from 2024-11-24 17-38-36
(spreadsheet)

@codecov

codecov Bot commented Nov 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (7f65171) to head (5ff3663).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8267      +/-   ##
==========================================
+ Coverage   88.94%   88.96%   +0.01%     
==========================================
  Files         303      303              
  Lines       41284    41273      -11     
==========================================
- Hits        36720    36718       -2     
+ Misses       4564     4555       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@holloway
holloway requested review from NGPixel and rjsparks November 24, 2024 04:56
@holloway
holloway marked this pull request as ready for review November 24, 2024 04:59
@holloway holloway changed the title fix: flakey playwright status tests fix: flaky playwright status tests Nov 24, 2024
@rjsparks
rjsparks merged commit a45f10c into ietf-tools:main Nov 25, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants