Skip to content

refactor: update secretariat dashboard style - #8140

Merged
rjsparks merged 8 commits into
ietf-tools:mainfrom
rpcross:secr-style
Apr 23, 2025
Merged

refactor: update secretariat dashboard style#8140
rjsparks merged 8 commits into
ietf-tools:mainfrom
rpcross:secr-style

Conversation

@rpcross

@rpcross rpcross commented Nov 3, 2024

Copy link
Copy Markdown
Contributor

No description provided.

rjsparks
rjsparks previously approved these changes Nov 3, 2024

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the failing tests - I think there's a problem around /static/ietf/js/announcement.js

@rjsparks

Copy link
Copy Markdown
Member

Hi @rpcross this seems to have fallen through the cracks?

@jennifer-richards

Copy link
Copy Markdown
Member

Probably should apply Black styling to the Python while you're at it?

@codecov

codecov Bot commented Apr 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.81%. Comparing base (35db339) to head (a3bd596).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ietf/secr/announcement/forms.py 93.75% 2 Missing ⚠️
ietf/secr/announcement/views.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8140      +/-   ##
==========================================
- Coverage   88.81%   88.81%   -0.01%     
==========================================
  Files         314      314              
  Lines       41430    41430              
==========================================
- Hits        36795    36794       -1     
- Misses       4635     4636       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpcross
rpcross requested a review from rjsparks April 23, 2025 15:59
@rjsparks
rjsparks merged commit 1bede71 into ietf-tools:main Apr 23, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants