feat: add group leadership list#8135
Conversation
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
The tests should probably check that rg groups are handled correctly. As it stands, I think rg groups could be ignored and the tests would still pass. (RoleFactory(group__type_id="rg", name_id="chair") might be a useful tool for that.
It'd also be nice to test that active/bof/proposed groups are included but, e.g., conclude groups are ignored. Here, RoleFactory(..., group__state_id="conclude", ...) might help.
FYI, the existing group you're seeing ("Sops") is set up in ietf/utils/test_data.py.
Suggest running the Black styler over the new code. (Or at least using double-quotes instead of single)
|
|
||
| def get_leadership(group_type): | ||
| people = Person.objects.filter( | ||
| role__name__slug="chair", |
There was a problem hiding this comment.
Not asking for a change now, but do think about the future when we might want to add IAB programs to these pages - we'll need to look for other role names at that point.
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Thanks for the changes!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8135 +/- ##
==========================================
+ Coverage 88.78% 88.94% +0.15%
==========================================
Files 296 303 +7
Lines 41320 41284 -36
==========================================
+ Hits 36687 36720 +33
+ Misses 4633 4564 -69 ☔ View full report in Codecov by Sentry. |
3 participants
No description provided.