Skip to content

feat: add wiki button to agenda list for hackathon sessions#8133

Merged
rjsparks merged 6 commits into
ietf-tools:mainfrom
NGPixel:agenda-hackathon
Dec 16, 2024
Merged

feat: add wiki button to agenda list for hackathon sessions#8133
rjsparks merged 6 commits into
ietf-tools:mainfrom
NGPixel:agenda-hackathon

Conversation

@NGPixel

@NGPixel NGPixel commented Nov 3, 2024

Copy link
Copy Markdown
Member
  • Adds a wiki button (blue book icon) in lieu of the notepad button for hackathon sessions (notepad being irrelevant and never used for them AFAIK). See below for example.
  • Replaces the special arrow symbol on the "Switch to text-only version" button while the agenda is loading with a standard » symbol. Should fix the arrow sometimes changing to a weird icon because of incorrect font / charset / font not loaded.

image

@NGPixel NGPixel requested a review from rjsparks November 3, 2024 09:19
Comment thread client/agenda/AgendaScheduleList.vue Outdated
Co-authored-by: Matthew Holloway <matthew@holloway.co.nz>
@rjsparks

rjsparks commented Nov 7, 2024

Copy link
Copy Markdown
Member

I'm not sure on this one.
I think we should split the arrow font out into its own PR.
I'd like to talk about generalizing this to other sessions that have different things than the default notes location.

@codecov

codecov Bot commented Dec 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (6b77807) to head (0f24975).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8133      +/-   ##
==========================================
+ Coverage   88.72%   88.73%   +0.01%     
==========================================
  Files         310      312       +2     
  Lines       40882    40915      +33     
==========================================
+ Hits        36273    36307      +34     
+ Misses       4609     4608       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 4a1d29e into ietf-tools:main Dec 16, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants