ci: replace nginx default.conf#8063
Merged
Merged
Conversation
NGPixel
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In deployments to date, we've put the datatracker's nginx configurations in
/etc/nginx/conf.d/alongside the default configuration from the docker image. Thedefault_serveroption on thelistendirective in our configuration normally causes our server to take precedence.This PR goes one step further and places our configuration over the default config. This eliminates the default "localhost" server that otherwise is still listening. Given how we route traffic, I don't think this is exposed in a harmful way, but better to replace it more thoroughly since it's never intended to be used.