Skip to content

fix: versioned href for slides URL#8040

Merged
rjsparks merged 1 commit intoietf-tools:mainfrom
jennifer-richards:versioned-meetecho-slides
Oct 14, 2024
Merged

fix: versioned href for slides URL#8040
rjsparks merged 1 commit intoietf-tools:mainfrom
jennifer-richards:versioned-meetecho-slides

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards commented Oct 10, 2024

Sends a versioned URL constructed by DocumentInfo.get_href() instead of get_versionless_href(). This should avoid cache-related issues when Meetecho updates their slides. It also fixes a bug (which, afaik, has not been encountered) where the latest slides would always be shown, even if a specific version was selected.

The comment about why get_versionless_href() was used appears to be stale - I think it was fixed in #7172, which was committed before any of this ever hit the main branch to begin with. I checked all the uses and do not see any situations where it a slides document (or related SessionPresentation) is changed/saved after a SlidesManager() method is called.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (c7f6bde) to head (5de8765).
Report is 94 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8040      +/-   ##
==========================================
+ Coverage   88.78%   88.89%   +0.10%     
==========================================
  Files         296      304       +8     
  Lines       41320    41302      -18     
==========================================
+ Hits        36687    36715      +28     
+ Misses       4633     4587      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Copy Markdown
Member

cc: @alexamirante (for awareness)

@rjsparks rjsparks merged commit 2d2e879 into ietf-tools:main Oct 14, 2024
@jennifer-richards jennifer-richards deleted the versioned-meetecho-slides branch October 14, 2024 15:41
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants