fix: turn off automatic escaping in session request templates#8007
fix: turn off automatic escaping in session request templates#8007rjsparks merged 4 commits intoietf-tools:mainfrom microamp:fix/7993
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8007 +/- ##
==========================================
+ Coverage 88.78% 88.84% +0.06%
==========================================
Files 296 304 +8
Lines 41320 41541 +221
==========================================
+ Hits 36687 36909 +222
+ Misses 4633 4632 -1 ☔ View full report in Codecov by Sentry. |
jennifer-richards
left a comment
There was a problem hiding this comment.
I'm a little concerned because this ends up outputting the user-provided person.name in an unescaped context. Since this is destined for plaintext email I think it's ok, but we should be careful.
|
If recipients honor the text/plain mime-type these are sent with, I don't think we have any concern (and we do use autoescape=off for most other templates that generate text for email. But I think we should, separately, turn up the level of sanitization of user input for names - they can be blobs, but the blobs don't need to contain html, for example. I've been toying with comparing the various names stored in the datatracker (and names we derive from them) with |
fixes #7993