fix: fix wg anchor tags (case-sensitive)#7995
fix: fix wg anchor tags (case-sensitive)#7995jennifer-richards merged 4 commits intoietf-tools:mainfrom microamp:fix/7994
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7995 +/- ##
==========================================
+ Coverage 88.78% 88.84% +0.05%
==========================================
Files 296 304 +8
Lines 41320 41541 +221
==========================================
+ Hits 36687 36907 +220
- Misses 4633 4634 +1 ☔ View full report in Codecov by Sentry. |
|
The IESG agenda page also has this issue. It's been addressed here, 4b2e45a. |
jennifer-richards
left a comment
There was a problem hiding this comment.
lgtm
Only comment is that there's a slight tension in hard-coding the /wg/ URL in the tests vs using urlreverse() to find it. I think it's probably ok either way because we're not likely to move the URL and it's a quick / obvious fix if we do.
rjsparks
left a comment
There was a problem hiding this comment.
Please address Jennifer's concern - use urlreverse instead of assuming /wg/).
I'd also suggest using jQuery to look for the element in the right place in the document rather than using assertContains - that may let you ignore the path part altogether and let you just test that the terminal part is capitialized.
pyquery? |
|
yes, I meant pyquery |
fixes #7994
In https://github.com/ietf-tools/datatracker/blob/main/ietf/templates/group/active_wgs.html, it uses
upper,so it's now doing the same on the area's side.