Skip to content

fix: fix wg anchor tags (case-sensitive)#7995

Merged
jennifer-richards merged 4 commits intoietf-tools:mainfrom
microamp:fix/7994
Oct 2, 2024
Merged

fix: fix wg anchor tags (case-sensitive)#7995
jennifer-richards merged 4 commits intoietf-tools:mainfrom
microamp:fix/7994

Conversation

@microamp
Copy link
Copy Markdown
Contributor

@microamp microamp commented Oct 1, 2024

fixes #7994

In https://github.com/ietf-tools/datatracker/blob/main/ietf/templates/group/active_wgs.html, it uses upper,

    {% for area in areas %}
        <h2 class="mt-5" id="{{ area.acronym|upper }}">{{ area.name }} ({{ area.acronym|upper }})</h2>

so it's now doing the same on the area's side.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (c7f6bde) to head (82970f0).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7995      +/-   ##
==========================================
+ Coverage   88.78%   88.84%   +0.05%     
==========================================
  Files         296      304       +8     
  Lines       41320    41541     +221     
==========================================
+ Hits        36687    36907     +220     
- Misses       4633     4634       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@microamp
Copy link
Copy Markdown
Contributor Author

microamp commented Oct 1, 2024

The IESG agenda page also has this issue. It's been addressed here, 4b2e45a.

@microamp microamp changed the title fix: fix wg anchor tags in areas page fix: fix wg anchor tags (case-sensitive) Oct 1, 2024
Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Only comment is that there's a slight tension in hard-coding the /wg/ URL in the tests vs using urlreverse() to find it. I think it's probably ok either way because we're not likely to move the URL and it's a quick / obvious fix if we do.

Copy link
Copy Markdown
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Jennifer's concern - use urlreverse instead of assuming /wg/).
I'd also suggest using jQuery to look for the element in the right place in the document rather than using assertContains - that may let you ignore the path part altogether and let you just test that the terminal part is capitialized.

@jennifer-richards
Copy link
Copy Markdown
Member

jQuery

pyquery?

@rjsparks
Copy link
Copy Markdown
Member

rjsparks commented Oct 2, 2024

yes, I meant pyquery

@jennifer-richards jennifer-richards merged commit 364dec3 into ietf-tools:main Oct 2, 2024
@microamp microamp deleted the fix/7994 branch October 2, 2024 23:30
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links to Areas on https://datatracker.ietf.org/area/ do not work as expected

3 participants