feat: warn about materials for cancelled sessions - #7959
Merged
Conversation
jennifer-richards
requested changes
Sep 23, 2024
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
See inline - for once, the test failure was real and not just factory-related noise
|
|
||
| session_statusid = None | ||
| if doc.session_set.count() == 1: | ||
| if doc.session_set.get().schedulingevent_set.exists(): |
Member
There was a problem hiding this comment.
Based on the test failure, this needs to handle the case that doc is a DocHistory
jennifer-richards
approved these changes
Sep 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7959 +/- ##
==========================================
+ Coverage 88.78% 88.84% +0.05%
==========================================
Files 296 304 +8
Lines 41320 41530 +210
==========================================
+ Hits 36687 36896 +209
- Misses 4633 4634 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses the remainder of #7455