Skip to content

fix: Change theme dynamically when system preferences change#7956

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
holloway:theme-change-dynamic
Sep 24, 2024
Merged

fix: Change theme dynamically when system preferences change#7956
rjsparks merged 1 commit into
ietf-tools:mainfrom
holloway:theme-change-dynamic

Conversation

@holloway

@holloway holloway commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

Although the theme was correctly applied on page load we weren't monitoring OS theme preference changes that occur afterwards. This watches for these changes and recalculates the theme

Fixes #7739

@holloway holloway changed the title Change theme dynamically when system preferences change fix: Change theme dynamically when system preferences change Sep 19, 2024
@holloway

Copy link
Copy Markdown
Contributor Author

fyi @rjsparks

@codecov

codecov Bot commented Sep 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (c7f6bde) to head (162c062).
Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7956      +/-   ##
==========================================
+ Coverage   88.78%   88.84%   +0.05%     
==========================================
  Files         296      304       +8     
  Lines       41320    41525     +205     
==========================================
+ Hits        36687    36891     +204     
- Misses       4633     4634       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
rjsparks merged commit 5ea4cc1 into ietf-tools:main Sep 24, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode changes are only partially applied to agenda

3 participants