test: check IPR search results in HTML with whitespace ignored#7921
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Sep 12, 2024
microamp:test/ipr-search-results
Merged
test: check IPR search results in HTML with whitespace ignored#7921rjsparks merged 1 commit intoietf-tools:mainfrom microamp:test/ipr-search-results
rjsparks merged 1 commit intoietf-tools:mainfrom
microamp:test/ipr-search-results
Conversation
Contributor
Author
|
The test failing above appears to be unrelated to this PR. Also, I could not reproduce it locally. ietf/manage.py test --settings=settings_test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7921 +/- ##
==========================================
+ Coverage 88.78% 88.83% +0.04%
==========================================
Files 296 304 +8
Lines 41320 41495 +175
==========================================
+ Hits 36687 36861 +174
- Misses 4633 4634 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
The job was re-run but failed again. https://github.com/ietf-tools/datatracker/actions/runs/10802493115/job/29971686883?pr=7921#step:6:1896 On the third attempt, all tests successfully passed. https://github.com/ietf-tools/datatracker/actions/runs/10802493127/job/29964665583?pr=7921 I'll create an issue re: reproducible tests unless there's one already. |
jennifer-richards
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the issue raised in #7836 (comment)
It's still important to group
together and test them as a whole for each assertion in the test.
All that was needed was to
html=Trueto each of theself.assertContainscallsEdit: See the official documentation on
assertContainsbelow.https://docs.djangoproject.com/en/4.2/topics/testing/tools/#django.test.SimpleTestCase.assertContains