feat: API changes needed for "real" draft imports#7877
Merged
jennifer-richards merged 10 commits intoietf-tools:feat/rpc-apifrom Sep 6, 2024
Merged
feat: API changes needed for "real" draft imports#7877jennifer-richards merged 10 commits intoietf-tools:feat/rpc-apifrom
jennifer-richards merged 10 commits intoietf-tools:feat/rpc-apifrom
Conversation
# Conflicts: # ietf/api/views_rpc.py
rjsparks
reviewed
Sep 3, 2024
| } | ||
| ) | ||
|
|
||
| "shepherd": d.shepherd.formatted_ascii_email() if d.shepherd else "", |
Member
There was a problem hiding this comment.
See my comment on the companion RPC PR - I'd rather not leak this information into the RPC app unless we really need to. The field will go through a big model change soon.
Collaborator
There was a problem hiding this comment.
The Document Shepherd email address is included in the CC of the AUTH48 messages
Member
There was a problem hiding this comment.
We could fetch that directly from the datatracker when generating the message.
Member
Author
There was a problem hiding this comment.
Leaving the shepherd email address in the API so it can be shown, but no longer storing it on the RPC side at all.
rjsparks
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the datatracker side of ietf-tools/purple#178