feat: Use meetecho-player.ietf.org for session recording#7873
Merged
rjsparks merged 4 commits intoietf-tools:mainfrom Sep 3, 2024
Merged
feat: Use meetecho-player.ietf.org for session recording#7873rjsparks merged 4 commits intoietf-tools:mainfrom
rjsparks merged 4 commits intoietf-tools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7873 +/- ##
==========================================
- Coverage 88.78% 88.78% -0.01%
==========================================
Files 296 304 +8
Lines 41320 41452 +132
==========================================
+ Hits 36687 36802 +115
- Misses 4633 4650 +17 ☔ View full report in Codecov by Sentry. |
Member
|
One issue (as I understand what we're currently doing and where this is headed) is that we'll produce links to this player for interms that didn't use meetecho (like moq). Can we add knowing if there's a meetecho recording to the database? Perhaps when a recording is pushed, the datatracker also gets an api hit that sets a bit on the relevant session? Or, less optimal, the datatracker looks to see if a recording exists before providing the URL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.