refactor: speed up finalizing proceedings - #7846
Merged
Merged
Conversation
The affiliation helper was extremely slow. Using queryset annotation speeds it up by almost an order of magnitude.
rjsparks
previously approved these changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7846 +/- ##
========================================
Coverage 88.78% 88.78%
========================================
Files 296 303 +7
Lines 41320 41422 +102
========================================
+ Hits 36687 36778 +91
- Misses 4633 4644 +11 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proceedings finalization for IETF-120 was timing out after 60s in production and taking almost 100s on my dev machine. Profiling showed almost all the time is spent generating bluesheets, heavily dominated by computing attendee affiliations. This PR rolls the annotation lookup into an
annotate()call in the query, which drops the total time to about 10s on my dev machine.For production deployments, this also increases the
proxy_read_timeout- that should perhaps be pulled out into its own PR.