fix: Install weasyprint as a xml2rfc extra#7845
Merged
Merged
Conversation
Since xml2rfc v3.23.0, WeasyPrint version is pinned.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7845 +/- ##
==========================================
+ Coverage 88.78% 88.80% +0.01%
==========================================
Files 296 303 +7
Lines 41320 41427 +107
==========================================
+ Hits 36687 36790 +103
- Misses 4633 4637 +4 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Aug 22, 2024
Member
|
I thought about dropping the explicit declaration of weasyprint from datatracker's requirements, relying on inheriting it from xml2rfc (to avoid some future update of the versions we require, perhaps coming in by automation, from breaking against the pin in xml2rfc), but making it obvious we have the dependency (for more than xml2rfc) is worth that maintenance burden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since xml2rfc v3.23.0, WeasyPrint version is pinned.
This will also enforce the
pydyfversion1.Footnotes
https://github.com/ietf-tools/xml2rfc/blob/main/setup.cfg#L59-L60 ↩