fix: remove unused notes field from SchedSessTimeAssignment model#7832
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7832 +/- ##
========================================
Coverage 88.78% 88.79%
========================================
Files 296 303 +7
Lines 41320 41428 +108
========================================
+ Hits 36687 36785 +98
- Misses 4633 4643 +10 ☔ View full report in Codecov by Sentry. |
jennifer-richards
approved these changes
Aug 20, 2024
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
Looks fine to me - I don't see any use of the field in js, vue, or html files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unclear what this column was ever intended to contain. All current objects have either None or "" for values. I've scrubbed the python for any use and haven't found any. Another careful pass, looking particularly for use in the js driving the agenda editing pages, would be prudent.