Skip to content

feat: Agenda URL #hash scrolls to 'now' or specific day - #7772

Merged
rjsparks merged 14 commits into
ietf-tools:mainfrom
holloway:feat/agenda-scroll-to-now
Aug 26, 2024
Merged

feat: Agenda URL #hash scrolls to 'now' or specific day#7772
rjsparks merged 14 commits into
ietf-tools:mainfrom
holloway:feat/agenda-scroll-to-now

Conversation

@holloway

@holloway holloway commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Fixes #7245

Allows scrolling to either #now or #agenda-day-YYYY-MM-DD on page load.

Adds a developer-only utility to modify server agenda dates to be the same as local browser time, so that the 'Now' button is available.

@holloway
holloway force-pushed the feat/agenda-scroll-to-now branch from 251fb76 to a852d9e Compare July 31, 2024 22:50
}

function scrollToNow (ev) {
ev.preventDefault()

@holloway holloway Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed so that when clicking 'Now' <a href="#now">Now</a>
Screenshot from 2024-08-01 10-52-50

...it will update the browser location with #now so that future reloads will have a hashstate that expresses 'Now'

@codecov

codecov Bot commented Jul 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (c7f6bde) to head (56f29b2).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7772      +/-   ##
==========================================
+ Coverage   88.78%   88.79%   +0.01%     
==========================================
  Files         296      303       +7     
  Lines       41320    41422     +102     
==========================================
+ Hits        36687    36782      +95     
- Misses       4633     4640       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holloway holloway changed the title feat: Agenda URL #now scrolls to current event feat: Agenda URL #hash scrolls to now or day Aug 14, 2024
@holloway holloway changed the title feat: Agenda URL #hash scrolls to now or day feat: Agenda URL #hash scrolls to 'now' or specific day Aug 14, 2024
@holloway
holloway marked this pull request as ready for review August 14, 2024 00:07
@holloway
holloway requested a review from rjsparks August 14, 2024 00:10
Comment thread client/agenda/store.js Outdated
@rjsparks

Copy link
Copy Markdown
Member

This is looking good on desktop, but on screens the size of an iphone 11, its not acting as intended. With the dev code uncommented, looking in this view, the now link doesn't change what's in the url bar, and pasting http://localhost:8000/meeting/agenda/#now into a blank tab doesn't cause the viewport to move to the red line.

@holloway

Copy link
Copy Markdown
Contributor Author

@rjsparks the functionality should work now. I still need to fix the tests.

@holloway

Copy link
Copy Markdown
Contributor Author

@rjsparks fixed. ready for review

@holloway
holloway requested a review from NGPixel August 22, 2024 00:21
Comment thread client/agenda/store.js Outdated
rjsparks
rjsparks previously approved these changes Aug 23, 2024
@rjsparks
rjsparks merged commit bece8fd into ietf-tools:main Aug 26, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button to go straight to “now”

3 participants