feat: Agenda URL #hash scrolls to 'now' or specific day#7772
Merged
rjsparks merged 14 commits intoietf-tools:mainfrom Aug 26, 2024
Merged
feat: Agenda URL #hash scrolls to 'now' or specific day#7772rjsparks merged 14 commits intoietf-tools:mainfrom
rjsparks merged 14 commits intoietf-tools:mainfrom
Conversation
251fb76 to
a852d9e
Compare
holloway
commented
Jul 31, 2024
| } | ||
|
|
||
| function scrollToNow (ev) { | ||
| ev.preventDefault() |
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7772 +/- ##
==========================================
+ Coverage 88.78% 88.79% +0.01%
==========================================
Files 296 303 +7
Lines 41320 41422 +102
==========================================
+ Hits 36687 36782 +95
- Misses 4633 4640 +7 ☔ View full report in Codecov by Sentry. |
…ker into feat/agenda-scroll-to-now
holloway
commented
Aug 14, 2024
Member
|
This is looking good on desktop, but on screens the size of an iphone 11, its not acting as intended. With the dev code uncommented, looking in this view, the now link doesn't change what's in the url bar, and pasting http://localhost:8000/meeting/agenda/#now into a blank tab doesn't cause the viewport to move to the red line. |
Contributor
Author
|
@rjsparks the functionality should work now. I still need to fix the tests. |
Contributor
Author
|
@rjsparks fixed. ready for review |
NGPixel
requested changes
Aug 22, 2024
…ings panel for debugging
rjsparks
previously approved these changes
Aug 23, 2024
NGPixel
approved these changes
Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7245
Allows scrolling to either
#nowor#agenda-day-YYYY-MM-DDon page load.Adds a developer-only utility to modify server agenda dates to be the same as local browser time, so that the 'Now' button is available.