fix: Document type badges

[holloway]

See #7475

[rjsparks]

why introduce new styling inline? Can this be moved to the css?

[rjsparks]

I think we still have inline styling in this branch and that it's being applied in cases that aren't intended - right now the tests are failing complaining about the inline styling, and because instead of this on main:

we're seeing this on the PR branch:

This is an active draft, so why the dashed lines, and what happened to the (stir WG) link?

[rjsparks]

That (stir WG) link is what's passed in as submission

[rjsparks]

@holloway : You've addressed my comments so far. What remains before this PR moves out draft status?

[rjsparks]

@holloway (or anyone else puzzled by the test failures earlier): at 1c3fd00 - the issue that caused test fails reporting an invalid document type of "Draft" was the compare and render using type vs type_id:

>>> from ietf.doc.models import Document
>>> d = Document.objects.filter(type_id="draft").last()
>>> type(d.type)
<class 'ietf.name.models.DocTypeName'>
>>> d.type=="draft"
False
>>> str(d.type)
'Draft'

One bit of django queryset syntactic "assistance" to be aware of. The following are equivalent, because the ORM does helpful work - assume dt = d.type from above (that is, dt is <DocTypeName: Draft>)

Document.objects.filter(type_id="draft")
Document.objects.filter(type="draft")
Document.objects.filter(type=dt)

All of which turn into this SQL

>>> str(Document.objects.filter(type=dt).query)
'SELECT "doc_document"."id", "doc_document"."time", "doc_document"."type_id", "doc_document"."title", 
"doc_document"."stream_id", "doc_document"."group_id", "doc_document"."abstract", "doc_document"."rev", 
"doc_document"."pages", "doc_document"."words", "doc_document"."intended_std_level_id", 
"doc_document"."std_level_id", "doc_document"."ad_id", "doc_document"."shepherd_id", "doc_document"."expires", 
"doc_document"."notify", "doc_document"."external_url", "doc_document"."uploaded_filename", "doc_document"."note", 
"doc_document"."internal_comments", "doc_document"."rfc_number", "doc_document"."name" FROM "doc_document" 
WHERE "doc_document"."type_id" = draft'

[rjsparks]

submission from the context is being lost here I think

[rjsparks]

this also needs the context?

[codecov]

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (c7f6bde) to head (42f3fa2).
Report is 51 commits behind head on main.

Files with missing lines	Patch %	Lines
ietf/doc/templatetags/document_type_badge.py	70.58%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7760      +/-   ##
==========================================
- Coverage   88.78%   88.78%   -0.01%     
==========================================
  Files         296      304       +8     
  Lines       41320    41439     +119     
==========================================
+ Hits        36687    36792     +105     
- Misses       4633     4647      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rjsparks]

Asking for a second review given the twisty passages

[jennifer-richards]

Just a couple minor things